Lidar Safety Node Advanced#62
Open
nathanestill wants to merge 15 commits into
Open
Conversation
ConnorNovak
requested changes
Sep 26, 2018
Member
There was a problem hiding this comment.
- Function docstring comments
- change "callback" to more specific - e.x. "lidar_cb"
- Not running anything . . .
- In run loop, check for "rospy.is_shutdown"
- Also, throw in a section that waits until it gets lidar data to run main loop. Put in run function.
- Last command in "if name == "main" should be calling run function.
- Set up a rospy.Rate()
- For var name and comments, reference base_link coordinate system
- Draw and save quick diagram labeling geometries
You're super cool though!
ConnorNovak
requested changes
Sep 26, 2018
Member
ConnorNovak
left a comment
There was a problem hiding this comment.
Please add downward-facing lidar and run some tests.
… from left to right
ConnorNovak
approved these changes
Dec 7, 2018
ConnorNovak
requested changes
Dec 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the code and made it nicer.